I’m no expert on film musicals. My favorites are The Band Wagon and Singin’ in the Rain.
This sequence from Broadway Melody of 1940 featuring Fred Astaire and Eleanor Powell is great. I love the mirrors and stars in the background.
Another great Eleanor Powell sequence